mirrors/p2pool-docker
1
0
Fork 1
mirror of https://github.com/sethforprivacy/p2pool-docker.git synced 2026-06-23 12:22:36 -04:00
Code Issues Packages Projects Releases Wiki Activity

Optimize final image: runtime libs instead of -dev, pin base image

Browse Source 
The final runtime stage installed full -dev packages (headers, static
archives, build-time deps) when only the runtime shared libraries are
needed. Replace them with the runtime-only equivalents, verified via
`ldd` on the built p2pool binary against the pinned base.

Changes:
- Final stage: install runtime libs instead of -dev packages
  (libuv1t64, libzmq5, libsodium23, libpgm-5.3-0t64, libnorm1t64,
  libgssapi-krb5-2, libcurl4t64, libidn2-0). Note the t64 names on
  Ubuntu 24.04 due to the 64-bit time_t transition.
- Pin both stages to ubuntu:24.04 (current LTS) instead of
  ubuntu:latest for reproducible builds. Renovate's docker manager
  keeps this current.
- Add --depth 1 --shallow-submodules to the git clone for faster,
  lighter source checkout.

Local verification (native arm64):
- Build succeeds (exit 0).
- `docker run --rm p2pool:test --help` prints "P2Pool v4.17" + usage.
- `ldd` on the binary in the final image: all libs resolve, none missing.
- Image size: 317MB -> 188MB (-129MB, -41%).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Seth For Privacy
2026-06-22 20:57:26 -04:00
parent a36f7e0a2f
commit c0187089f4
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Dockerfile
View File

@@ -1,7 +1,7 @@
ARG P2POOL_BRANCH=v4.17
# Select latest Ubuntu LTS for the build image base
FROM ubuntu:latest as build
# Pin to the latest Ubuntu LTS for the build image base (kept current by Renovate)
FROM ubuntu:24.04 as build
LABEL author="sethforprivacy@protonmail.com" \
maintainer="sethforprivacy@protonmail.com"
@@ -24,20 +24,22 @@ WORKDIR /p2pool
# Git pull p2pool source at specified tag/branch
ARG P2POOL_BRANCH
RUN git clone --recursive --branch ${P2POOL_BRANCH} https://github.com/SChernykh/p2pool .
RUN git clone --recursive --depth 1 --shallow-submodules --branch ${P2POOL_BRANCH} https://github.com/SChernykh/p2pool .
# Make static p2pool binary
ARG NPROC
RUN test -z "$NPROC" && nproc > /nproc || echo -n "$NPROC" > /nproc && mkdir build && cd build && cmake .. && make -j"$(cat /nproc)"
# Select latest Ubuntu LTS for the image base
FROM ubuntu:latest
# Pin to the latest Ubuntu LTS for the image base (kept current by Renovate)
FROM ubuntu:24.04
# Install remaining dependencies
# Install only the runtime shared libraries that the p2pool binary links against
# (runtime equivalents of the build-stage -dev packages, verified via ldd on the
# built binary against the pinned Ubuntu 24.04 base)
RUN apt-get update \
&& apt-get upgrade -y \
&& apt-get install --no-install-recommends -y libuv1-dev libzmq3-dev libsodium-dev \
libpgm-dev libnorm-dev libgss-dev libcurl4-openssl-dev libidn2-0-dev \
&& apt-get install --no-install-recommends -y libuv1t64 libzmq5 libsodium23 \
libpgm-5.3-0t64 libnorm1t64 libgssapi-krb5-2 libcurl4t64 libidn2-0 \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*